User talk:Markfeh

From Fire Emblem Heroes Wiki
Jump to: navigation, search
Past Discussions

About moving Hero descriptions[edit source]

Based on your edits, I think you don't know how to do that properly. Your edits deleted some rows from HeroDescriptions table, and some pages that depend on it might be broken. Here are what you should do:

  • Edit {{Hero Infobox}} so that it stores descriptions to the Heroes table (you already did).
  • Ask an admin to recreate the table.
  • Copy descriptions from {{HeroPageText}} to description parameter in all Hero pages, but DO NOT remove {{HeroPageText}} (this task can be done by a bot).
  • After all pages were edited, ask an admin again to replace the old Heroes table with the new one.
  • Check all pages that query HeroDescriptions table, and fix them so that they query to the new Heroes table.
  • Remove {{HeroPageText}} in all Hero pages (this task can be done by a bot).
  • Ask an admin again to delete HeroDescriptions table. --RainThunder0 (talk) 14:05, 12 February 2019 (UTC)
Thanks for all of the information. I have done this before with {{MoveType Infobox}} and {{WeaponType Infobox}}, but it is a bit more complicated since there are still 327 heroes that need their descriptions moved from {{HeroPageText}} to the description parameter. That's too much for me to do manually. My plan was to ask someone to use a bot (I don't know how to use bots.) to move descriptions from {{HeroPageText}} to the description parameter in all Hero pages, and remove {{HeroPageText}} at the same time. Then I was going to ask an admin to delete HeroDescriptions and replace Heroes and Enemies. After that is done, then {{HeroPage}} needs to be modified to query for descriptions in Heroes and Enemies. Markfeh (talk) 16:35, 12 February 2019 (UTC)

Unnecessary parameter removal[edit source]

Please don't remove parameters from templates for no reason. Regarding your recent Hero page edits, whoever added the parameters like OldSummonRarities, rarityChangeDate probably had a reason for doing so. They are parameters with possibilities, and there is no downside to them being there. They can potentially be used in the future, and also happens to be the only place this data is stored. Please do not remove parameters for no other reason besides just that you think that they do nothing. GrowthModifier should not be removed. Unknown type information and empty, N/A, 0 or other information of similar nature are not the same thing. Endilyn (talk) 01:56, 21 February 2019 (UTC)

OldSummonRarities and rarityChangeDate are not defined in {{Hero Infobox}} or Heroes. |Properties=demoted_240 already adds what they probably did originally. If there are more rarity demotions in the future another property can always be added. Markfeh (talk) 02:38, 21 February 2019 (UTC)

It does not matter whether it is implemented in the template or described in the documentation or not. This is why I called them parameters with possibilities. type=HO in Heroic Ordeals map layouts is not implemented or documented but that does not mean there is a reason to remove it. A lack of a perceived reason to keep something does not automatically equate to a reason to remove something. If you are removing information you should remove it because of a reason to remove it and not a lack of reason to keep it, especially is there is a possible, however minor, benefit, to keeping it, but no downsides.

I overlooked the demoted_240 when posting, and your reasoning that demoted_240 already contains all the possible data these parameters could have is sufficient reasoning. I just checked and since the old demotion date and old rarities are constant and exactly the same for each Hero, the single property can be expanded to all of the needed information (if Intelligent Systems had not demoted everyone based on a single pattern with no exceptions, or had demoted more than one rarity tier, demoted_240 alone would not be able to contain the equivalent amount of information).

Endilyn (talk) 01:37, 22 February 2019 (UTC)

Profile Comments[edit source]

I've noticed you doing this a couple of times now, but unless you're actually undoing an edit, please don't press the undo button. Doing that will make things slightly harder to follow in edit history. If you want to edit an old revision, simply click the edit button next to the old revision.Endilyn on
If you are going to move old banner names, please go all the way and update old references as well instead of leaving redirects to ambiguous names.Endilyn on

Move pages, don't paste to a new page[edit source]

If you need to move a page but lack the rights to do so then you can ask an admin and wait. It's not particularly time vital that all skill pages be moved this instant. You have effectively erased page history for all of those skill pages you moved. Endilyn (talk) 04:00, 1 March 2019 (UTC)

Also, moving skill pages was in the to-do list's larger more involved tasks for a reason. Actions should be carefully reviewed before performing them, as there may be additional requirements/consequences that are not obvious at first glance. You cannot simply only rename the skill and make an edit to the Hero page to complete the task. It is involved because you need to replace all instances where the page name was used. This is also listed in the requirements for this task. This includes, but is not limited to, map pages, and Children of the Shadow for example has a broken display for Soleil now. The next time you do a task in this list you should test your changes as you go along. If you do not know the extent of your changes, you should have tested and moved only one skill page, and verified the extent of any damage that may have caused with that change if any, before doing the page moves for the rest. Endilyn (talk) 04:10, 1 March 2019 (UTC)

WikiName[edit source]

It seems that you may not know the purpose of the WikiName fields judging from some of your interactions involving the field, such as removing it from some templates, setting Berserk Armads's WikiName to "Armads", or using "Firesweep Lance+" as a WikiName. You can read more about the field at Project:Tutorials/Cargo#Common fields on the wiki. Endilyn (talk) 07:33, 2 March 2019 (UTC)

UserProfile[edit source]

I sometimes comment because I want to say something quick/short/simple/whatever. If you don't like gamepedia's UserProfile system, then that's fine, you are not obligated to respond to anything posted on your profile. That message telling others to use your talk page is fine as well. However, removing comments of others for no reason is extremely discourteous (and basically amounts to censorship). Users have the freedom to use any system of communication they want, be it talk page or UserProfile. Endilyn (talk) 02:00, 6 March 2019 (UTC)

Template editing[edit source]

It seems that recently when you edit a template you publish an edit for every minor test made, sometimes resulting in no net change being made. When making complicated edits to live templates used around the wiki, if you can please try to preview your edits before publishing them, especially for very important templates used in many places. This might be helpful to know: anything in the noinclude section of a template allows you to preview unsaved changes. This means that for example, if you edited a template named foo and put {{foo}} in noinclude, when you hit preview your changes affect what {{foo}} shows in the preview, even if it hasn't been saved yet. Alternatively, if a template cannot easily be tested because it depends on the page name or something like that, you can try using or creating various test templates like Template:Hero Infobox Test or Module:Test3, then copy the source to the real template afterwards. Endilyn (talk) 04:03, 13 March 2019 (UTC)

Usually when I'm testing changes to a template the changes don't show at all (unless the template does not have any <includeonly> and/or <onlyinclude> in it). This happens even when I add something like {{Hero Infobox|newparameter=something}} between the <noinclude></noinclude> tags and then hit preview. I don't know if it is a problem with the devices I use, the browser I use, or the wiki editor, but changes to a template never show up for me until after I've saved the change. Markfeh (talk) 04:37, 13 March 2019 (UTC)
I've just tested with stock Google Chrome and Firefox (no cookies, cache etc., logged out) and it seems to work fine and is enabled by default. It doesn't appear to be a browser issue. Are you using the source editor? Have you accidentally turned it this feature off in preferences somehow? I'll let you know if I ever figure this out since this feature is immensely helpful. Endilyn (talk) 04:54, 13 March 2019 (UTC)
I have tested tested with the same things, and it just doesn't seem to work for me. I have been using the source editor, the only thing I disabled in in the editing tab of my prefrences was the visual editor, because it is too cumbersome to use. Markfeh (talk) 05:09, 13 March 2019 (UTC)

So, what warranted the Builds pages for Valor and Experience passives being removed (according to me)?[edit source]

First, as I mentioned in the Delete template, these passive skills provide no benefit for use in the majority of gamemodes if you discount the opportunities where SP can be gained (because experience points can only be gained until you hit Lvl. 40). And yeah, my method clashes with the idea for consistency on this Wiki which makes quite a difference compared to me simplifying the daily Hero Battle maps rotation, but it still stands that for serious play and Chain maps you should (when you can) swap out the Exp/Valor passives for a desired one. --TheBreakingBenny (talk) 10:25, 9 April 2019 (UTC)